[fix] Custom HTTPS files results in error:0909006C:PEM routines:get_name:no start line

[ryc76]

Specifying HTTPS key pair in Vite config fails causes dev server to fail

example config

server: {
		ssr: true,
		https: {
			key: '/privkey.pem',
			cert: '/fullchain.pem'
		}
	},

Run npx svelte-kit dev --https

Results in

error:0909006C:PEM routines:get_name:no start line

Vite was being passed the path of the files rather the file themselves.

Odd as I'm sure this used to work.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0135b58

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[benmccann]

it'd probably be nice to add a blank line after this one for style consistency

[benmccann]

This would need a changeset

It'd be nice to know if this was always broken or broke recently. Maybe a Vite upgrade broke it? I wonder if it works with an older version of Vite

[Rich-Harris]

I'm not sure I follow — Vite isn't involved in this process, the code changed in this PR is SvelteKit's own helper for starting an http/https server. Did this work in a previous version? I'd be inclined to keep the current behaviour — it's easy to do fs.readFileSync inside your config file, but if it's expecting a filename then you can't pass a value directly

[ryc76]

This would need a changeset

It'd be nice to know if this was always broken or broke recently. Maybe a Vite upgrade broke it? I wonder if it works with an older version of Vite

I believe this commit broke it

5aa64ab
#844

[benmccann]

I believe this commit broke it

@ryc76 can you explain what the breakage was? I'm not seeing that the referenced PR did anything with either of those options

[ryc76]

I've revisited and can't get this working with older commits as I thought I could. I'm happy to go with @Rich-Harris suggestion of using fs.readFileSync inside the svelte.config.js