Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] export package.json from adapters #2351

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Conversation

benmccann
Copy link
Member

We always tell people they should export package.json, so we should probably follow our own advice 😄

@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2021

🦋 Changeset detected

Latest commit: 7fc79b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@sveltejs/adapter-begin Patch
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-node Patch
@sveltejs/adapter-static Patch
@sveltejs/adapter-vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann merged commit e8d60f3 into master Sep 2, 2021
@benmccann benmccann deleted the export-package-json branch September 2, 2021 15:58
@github-actions github-actions bot mentioned this pull request Sep 2, 2021
@jthegedus
Copy link
Contributor

What's the motivation for this? I apparently have never read any of the "We always tell people" conversations.

@benmccann
Copy link
Member Author

If you don't export package.json then tooling can't access it. There's some tooling like rollup-plugin-svelte that tries to access the package.json of every package (e.g. to determine if it's a Svelte package in that case) and you will get an error if it's not exported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants