Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundle worktop #4473

Merged
merged 4 commits into from
Mar 31, 2022
Merged

bundle worktop #4473

merged 4 commits into from
Mar 31, 2022

Conversation

Rich-Harris
Copy link
Member

Bundles worktop so that apps don't need to install it — see #4453 (comment)

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 983c95a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris mentioned this pull request Mar 31, 2022
Merged
5 tasks
lukeed
lukeed approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels wrong, but it gets the job done i guess

I'll update my PR with the extra changes necessary for the build paths

@lukeed lukeed merged commit 77702f9 into chore/cloudflare-worktop Mar 31, 2022
@lukeed lukeed deleted the chore/cloudflare-worktop-bundled branch March 31, 2022 17:06
Rich-Harris added a commit that referenced this pull request Mar 31, 2022
@lukeed @Rich-Harris
chore(cloudflare): optimize Cache usage; strict TS source (#4453)
316943f 
* chore(cloudflare): optimize Cache usage; strict TS source

* chore: add changeset

* skip lib check for conflicts

* bundle worktop (#4473)

* bundle worktop

* build on prepublishOnly

* Update packages/adapter-cloudflare/tsconfig.json

* update builder file paths

Co-authored-by: Luke Edwards <[email protected]>

* convert to JS (#4474)

* Update .changeset/empty-falcons-run.md

Co-authored-by: Rich Harris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeed lukeed lukeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rich-Harris @lukeed