Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify that base path can be the empty string #4713

Merged
merged 2 commits into from
Apr 24, 2022
Merged

Conversation

Rich-Harris
Copy link
Member

Apparently some people get confused by this (e.g. #1329)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2022

🦋 Changeset detected

Latest commit: ef2683e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit f749b55 into master Apr 24, 2022
@Rich-Harris Rich-Harris deleted the clarify-base-path branch April 24, 2022 22:56
@Conduitry
Copy link
Member

This broke tests for me in https://github.com/sveltejs/kit/tree/master/packages/kit/src/core/config/index.spec.js (which I would expect because it changed an error message, and they're now looking for the wrong one), but CI is still passing, which is bugging me.

@mrkishi
Copy link
Member

mrkishi commented Apr 25, 2022

Apparently the tests haven't been running since #4707, the green/neutral checks are Netlify/Cloudflare/Vercel checks.

I think include should be an array instead, #4727 seems to be running the tests.

@Conduitry
Copy link
Member

Ah, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants