Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent scroll when resetting page focus (#4065) #4846

Merged
merged 3 commits into from
May 13, 2022
Merged

prevent scroll when resetting page focus (#4065) #4846

merged 3 commits into from
May 13, 2022

Conversation

timothycohen
Copy link
Contributor

Fixes #4065. While resetting focus, Safari was scrolling over the top margin.

As it’s a Safari specific issue, the change in test from fail to pass is only visible when running Playwright with WebKit.

This is my first PR, so let me know if I missed something in the workflow, thanks!

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented May 7, 2022

🦋 Changeset detected

Latest commit: 30ad83c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 477d860 into sveltejs:master May 13, 2022
@Rich-Harris
Copy link
Member

excellent, thank you!

@timothycohen timothycohen deleted the 4065 branch May 14, 2022 16:21
@Rich-Harris Rich-Harris mentioned this pull request May 15, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page scrolls down on load
3 participants