Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Vite 3 #5005

Merged
merged 51 commits into from
Jul 14, 2022
Merged

Upgrade to Vite 3 #5005

merged 51 commits into from
Jul 14, 2022

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented May 20, 2022 •
edited
Loading

Announcement blog post: https://vitejs.dev/blog/announcing-vite3.html

Some changes noticeable for SvelteKit:

  • relative base support (Dynamic basepath #595)
  • default port changed to 5173 in development mode
  • fixStacktrace now defaults to false
  • We can now set appType: 'custom' so that HTML middlewares are not added and we no longer have to remove many of them

v3 also added a new hook configurePreviewServer that has been backported to 2.9 and already leveraged in SvelteKit master which allowed us to switch to the vite CLI

@changeset-bot
Copy link

changeset-bot bot commented May 20, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 293d564

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

what do 'disable spa' and 'configurePreviewServer' mean?

@benmccann
Revert "argh"
f91a711 
This reverts commit 9e2d017.
benmccann and others added 5 commits July 13, 2022 21:51
@benmccann
[docs] add JSDocs for Vite build process
9a90c35
@benmccann
format
4f8bbd1
@ignatiusmb
loop over values instead with Object.values
d9a059c
@ignatiusmb
missed a closing bracket
7496850
@dominikg
fix: ensure isolated testing of create-svelte with local packages (#5524
77f4abe 
)

* fix: move create-svelte test working dir out of pnpm workspae

* fix: copy-paste error, adapter-auto override

* fix: readd check command

* fix: ensure that create-svelte tests generate test apps outside our main pnpm workspace

* fix format

* fix: readd --no-frozen-lockfile to override pnpm default when CI is true
@Rich-Harris Rich-Harris mentioned this pull request Jul 14, 2022
Closed
@Rich-Harris Rich-Harris merged commit d430a33 into master Jul 14, 2022
@Rich-Harris Rich-Harris deleted the vite-3 branch July 14, 2022 15:26
@Rich-Harris Rich-Harris mentioned this pull request Jul 14, 2022
Merged
@stephane-klein stephane-klein mentioned this pull request Jul 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
breaking change vite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@benmccann @Rich-Harris @richarddavenport @asuraphel @ignatiusmb @dominikg