Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove cwd as a method parameter #5040

Merged
merged 1 commit into from
May 23, 2022
Merged

[chore] remove cwd as a method parameter #5040

merged 1 commit into from
May 23, 2022

Conversation

benmccann
Copy link
Member

I don't think this needs to be passed around. Removing it simplifies things and results in less code. And if we want to use the vite CLI then we won't be able to pass it in the way we can from the svelte-kit CLI

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2022

⚠️ No Changeset found

Latest commit: 788e294

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann marked this pull request as ready for review May 23, 2022 22:44
@benmccann benmccann merged commit 7ee26ad into master May 23, 2022
@benmccann benmccann deleted the cwd branch May 23, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants