fix(5383): undici works better with two arguments #5396
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5383
I don't know why this works better, but something is wrong on undici's side at step 25:
https://github.com/nodejs/undici/blob/5ca25c23500d649a629865d9a7a28ce653d5e991/lib/fetch/request.js#L321-L341
Specifically, when only one argument is given (as before this PR),
init.method
gets a default value ofGET
and erasesrequest.method
.After a bit of research, this was fixed in nodejs/undici#1529
For people that want a quick workaround: patch
node_modules/@sveltejs/kit/assets/server/index.js:2304
with:and restart the dev server.
I'll open the PR nonetheless because svelte-kit seems to release faster than undici.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0