-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adapter-static
throws buildtime error when !config.kit.prerender.default && !adapter.fallback
#5562
Conversation
🦋 Changeset detectedLatest commit: 019e097 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -3,7 +3,7 @@ import adapter from '../../../../adapter-static/index.js'; | |||
/** @type {import('@sveltejs/kit').Config} */ | |||
const config = { | |||
kit: { | |||
adapter: adapter(), | |||
adapter: adapter({ fallback: '200.html' }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we rename the app from disabled
to fallback
? This test app looks a bit weird as it doesn't check any of the output or anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, done
…tcc-sejohnson/kit into sejohnson-improve-adapter-static-errors
Closes #5185.
Quite possibly the smallest git diff I've PRed recently.
There are no additional tests as I'm not sure what the best way to test this is. It'd require a new app and a test that could try to run
npm run build
and make sure it fails with the necessary error.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0