Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR number in CHANGELOG.md #5697

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Update PR number in CHANGELOG.md #5697

merged 1 commit into from
Jul 25, 2022

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented Jul 25, 2022

Automated tooling got the PR number wrong, so let's fix it. Specifically, #5683 is the PR that actually contains the code changes and justification for the changes. #5684 contains just the changeset that was forgotten in #5683. So the automated tooling picked up #5684 as the PR to put in the changelog, but #5683 is the one that anyone reading the changelog will actually care about. By switching the changelog contents to point to #5683 for this release, we let everyone avoid having to make an additional click to find the actually useful information.

I'm not including a changeset in this PR since it makes no code changes. Likewise, no issue link and no tests.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Automated tooling got the PR number wrong, so let's fix it.
@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2022

⚠️ No Changeset found

Latest commit: 38549e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants