-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin incompatible with Node.js exports
package.json field
#104
Comments
I was having the same problem with the I only saw this discussion afterwards, but it seems like it follows in the direction you mentioned, of making it an acceptable error. I could use some feedback on the actual implementation though, there's probably a better way of getting the resolved file name other than parsing the error message. |
Another example: https://github.com/bvaughn/js-search
|
And here is another one: marijnh/w3c-keyname#10 |
This plugin tries to resolve the
package.json
files of processed modules:rollup-plugin-svelte/index.js
Lines 177 to 180 in 85d25fb
This breaks with npm modules that make use of the new
exports
field but do not specify a subpath export for thepackage.json
file.This issue surfaced in uuidjs/uuid#444
IMO this plugin can no longer expect that every npm module exports the
package.json
file and the resolver logic has to be adjusted accordingly.Maybe in
rollup-plugin-svelte/index.js
Lines 48 to 55 in 85d25fb
we could add
ERR_PACKAGE_PATH_NOT_EXPORTED
as an "acceptable" error as well?The text was updated successfully, but these errors were encountered: