-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Svelte 5 RC to peerDeps #219
base: master
Are you sure you want to change the base?
Conversation
@@ -30,7 +30,7 @@ | |||
}, | |||
"peerDependencies": { | |||
"rollup": ">=2.0.0", | |||
"svelte": ">=3.5.0" | |||
"svelte": ">=3.5.0 || >=5.0.0-next.120" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would imagine we should allow any pre-release version here
"svelte": ">=3.5.0 || >=5.0.0-next.120" | |
"svelte": ">=3.5.0 || >=5.0.0-next.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really have an opinion on it. I chose 120 to just peg it to the release candidate. I'm not sure how many people would be using the pre-release who wouldn't want to update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to commit this change if you want it.
I don't know if we want to do this or not. I'll defer to the other maintainers. The other alternative would be that you can ignore the peer dependency warnings |
Sounds good. Fine either way. The workaround for me was to use the |
I think it's fine by me to add this. Seems like @dummdidumm made commits a couple months ago to support Svelte 5. |
Per #218, adds the Svelte 5 Release Candidate as an allowable peer dependency.