Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Fix for detaching meta in <svelte:head> #793

Closed
wants to merge 1 commit into from

Conversation

matyunya
Copy link

@matyunya matyunya commented Jul 6, 2019

Fix for the problem discovered here:
sveltejs/sapper-template#158

Page transition breaks if there's meta tag inside <svelte:head>.

@Conduitry
Copy link
Member

Do we know why these nodes don't have a parentNode by the time we call this? Have they already been detached by some other code?

@evdama
Copy link

evdama commented Jul 6, 2019

No idea, but svelte has the same issue sveltejs/svelte#3188

@mrkishi
Copy link
Member

mrkishi commented Jul 6, 2019

I believe the actual problem would be solved by sveltejs/svelte#3172, no?

e: I totally meant to post this in the Svelte issue, oops.

@Conduitry
Copy link
Member

See sveltejs/svelte#3187 (comment) - this isn't the right place to solve this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants