feat: update type of $props rune (#510)

Co-authored-by: Yosuke Ota <[email protected]>
sveltejs · Apr 22, 2024 · 9dddc36 · 9dddc36
1 parent 04cf54c
commit 9dddc36
Show file tree

Hide file tree

Showing 31 changed files with 5,911 additions and 6,041 deletions.
diff --git a/.changeset/smooth-elephants-mate.md b/.changeset/smooth-elephants-mate.md
@@ -0,0 +1,5 @@
+---
+"svelte-eslint-parser": patch
+---
+
+feat: update type of $props rune
diff --git a/explorer-v2/src/lib/MonacoEditor.svelte b/explorer-v2/src/lib/MonacoEditor.svelte
@@ -238,10 +238,13 @@
 
 {#await loading}
 	{#if started}
-		<div class="eslint-editor-monaco-root eslint-editor-monaco-root--wait" in:loadingTypewriter />
+		<div
+			class="eslint-editor-monaco-root eslint-editor-monaco-root--wait"
+			in:loadingTypewriter
+		></div>
 	{/if}
 {:then}
-	<div bind:this={rootElement} class="eslint-editor-monaco-root" />
+	<div bind:this={rootElement} class="eslint-editor-monaco-root"></div>
 {/await}
 
 <style>

diff --git a/explorer-v2/src/routes/+layout.svelte b/explorer-v2/src/routes/+layout.svelte
@@ -14,7 +14,7 @@
 		position: relative;
 		height: calc(100vh - 64px);
 	}
-	.main > * {
+	.main > :global(*) {
 		position: relative;
 		width: 100%;
 		height: 100%;

diff --git a/package.json b/package.json
@@ -47,7 +47,7 @@
     "version:ci": "env-cmd -e version-ci pnpm run build:meta && changeset version"
   },
   "peerDependencies": {
-    "svelte": "^3.37.0 || ^4.0.0 || ^5.0.0-next.94"
+    "svelte": "^3.37.0 || ^4.0.0 || ^5.0.0-next.112"
   },
   "peerDependenciesMeta": {
     "svelte": {
@@ -105,7 +105,7 @@
     "prettier-plugin-svelte": "^3.2.2",
     "rimraf": "^5.0.5",
     "semver": "^7.6.0",
-    "svelte": "^5.0.0-next.94",
+    "svelte": "^5.0.0-next.112",
     "svelte2tsx": "^0.7.6",
     "typescript": "~5.4.4",
     "typescript-eslint-parser-for-extra-files": "^0.6.0"

diff --git a/src/parser/converts/element.ts b/src/parser/converts/element.ts
@@ -211,7 +211,7 @@ export function* convertChildren(
       continue;
     }
 
-    throw new Error(`Unknown type:${(child as any).type}`);
+    throw new Error(`Unknown type:${child.type}`);
   }
 }
 

diff --git a/src/parser/typescript/analyze/index.ts b/src/parser/typescript/analyze/index.ts
@@ -354,7 +354,7 @@ function analyzeRuneVariables(
       }
       // See https://github.com/sveltejs/svelte/blob/dfc55c18f010f620b966e13eb0ad1f9791b5798f/packages/svelte/types/index.d.ts#L2655
       case "$props": {
-        appendDeclareFunctionVirtualScripts(globalName, ["<T>(): T"]);
+        appendDeclareFunctionVirtualScripts(globalName, ["(): any"]);
         break;
       }
       // See https://github.com/sveltejs/svelte/blob/dfc55c18f010f620b966e13eb0ad1f9791b5798f/packages/svelte/types/index.d.ts#L2666

diff --git a/tests/fixtures/parser/ast/svelte5/docs/runes/08-$props-ts-input.svelte b/tests/fixtures/parser/ast/svelte5/docs/runes/08-$props-ts-input.svelte
@@ -1,4 +1,4 @@
 <script lang="ts">
-    type MyProps = {}
-    let { a, b, c, ...everythingElse } = $props<MyProps>();
+  type MyProps = {};
+  let { a, b, c, ...everythingElse }: MyProps = $props();
 </script>
diff --git a/tests/fixtures/parser/ast/svelte5/docs/runes/08-$props-ts-no-unused-vars-result.json b/tests/fixtures/parser/ast/svelte5/docs/runes/08-$props-ts-no-unused-vars-result.json
@@ -3,24 +3,24 @@
     "ruleId": "no-unused-vars",
     "code": "a",
     "line": 3,
-    "column": 11
+    "column": 9
   },
   {
     "ruleId": "no-unused-vars",
     "code": "b",
     "line": 3,
-    "column": 14
+    "column": 12
   },
   {
     "ruleId": "no-unused-vars",
     "code": "c",
     "line": 3,
-    "column": 17
+    "column": 15
   },
   {
     "ruleId": "no-unused-vars",
     "code": "everythingElse",
     "line": 3,
-    "column": 23
+    "column": 21
   }
 ]