fix: add quotes to ts store regex (#403)

Fixes #402 Co-authored-by: Simon Holthausen <[email protected]>
sveltejs · Sep 8, 2021 · 9f2d7a0 · 9f2d7a0
1 parent d73319c
commit 9f2d7a0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/transformers/typescript.ts b/src/transformers/typescript.ts
@@ -138,7 +138,7 @@ function injectVarsToCode({
   // TODO investigate if it's possible to achieve this with a
   // TS transformer (previous attemps have failed)
   const codestores = Array.from(
-    content.match(/\$[^\s();:,[\]{}.?!+-=*/~|&%<>^]+/g) || [],
+    content.match(/\$[^\s();:,[\]{}.?!+-=*/~|&%<>^`"']+/g) || [],
     (name) => name.slice(1),
   ).filter((name) => !JAVASCRIPT_RESERVED_KEYWORD_SET.has(name));
 

diff --git a/test/fixtures/TypeScriptImports.svelte b/test/fixtures/TypeScriptImports.svelte
@@ -19,7 +19,10 @@
     const obj = {
         fn: () => "test",
         val: "test1" as const,
-        $in: ""
+        $in: "",
+        a: "$",
+        b: '$',
+        c: `$`
     };
     let inputVal: string;
     const action = (node: Element, options: { id: string; }) => { node.id = options.id; };