fix: ensure SVG element attributes have case preserved (#13935)

* fix: ensure SVG element attributes have case preserved * fix: ensure SVG element attributes have case preserved * fix: ensure SVG element attributes have case preserved
sveltejs · Oct 25, 2024 · 441124c · 441124c
1 parent feb2d85
commit 441124c
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 1 deletion.
diff --git a/.changeset/gentle-bulldogs-cough.md b/.changeset/gentle-bulldogs-cough.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: ensure SVG element attributes have case preserved
diff --git a/packages/svelte/src/compiler/phases/3-transform/client/visitors/SvelteElement.js b/packages/svelte/src/compiler/phases/3-transform/client/visitors/SvelteElement.js
@@ -101,7 +101,7 @@ export function SvelteElement(node, context) {
 			node,
 			element_id,
 			attributes_id,
-			b.binary('!==', b.member(element_id, 'namespaceURI'), b.id('$.NAMESPACE_SVG')),
+			b.binary('===', b.member(element_id, 'namespaceURI'), b.id('$.NAMESPACE_SVG')),
 			b.call(b.member(b.member(element_id, 'nodeName'), 'includes'), b.literal('-')),
 			context.state
 		);

diff --git a/packages/svelte/tests/runtime-runes/samples/svg-attribute-case/_config.js b/packages/svelte/tests/runtime-runes/samples/svg-attribute-case/_config.js
@@ -0,0 +1,5 @@
+import { test } from '../../test';
+
+export default test({
+	html: `<svg viewBox="0 0 10 10"></svg><svg viewBox="0 0 10 10" xmlns="http://www.w3.org/2000/svg"></svg><svg viewBox=""></svg>`
+});
diff --git a/packages/svelte/tests/runtime-runes/samples/svg-attribute-case/main.svelte b/packages/svelte/tests/runtime-runes/samples/svg-attribute-case/main.svelte
@@ -0,0 +1,4 @@
+<svelte:options namespace="svg" />
+<svelte:element this="svg" viewBox="0 0 10 10" />
+<svelte:element this="svg" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 10 10" />
+<svg viewBox="" />