use setAttribute with inputs, for benefit of IE - fixes #1209

sveltejs · Mar 14, 2018 · 4e99eb8 · 4e99eb8
1 parent 0ac7701
commit 4e99eb8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/src/generators/nodes/Attribute.ts b/src/generators/nodes/Attribute.ts
@@ -518,7 +518,6 @@ const attributeLookup = {
 	type: {
 		appliesTo: [
 			'button',
-			'input',
 			'command',
 			'embed',
 			'object',

diff --git a/test/js/samples/input-without-blowback-guard/expected-bundle.js b/test/js/samples/input-without-blowback-guard/expected-bundle.js
@@ -33,6 +33,10 @@ function removeListener(node, event, handler) {
 	node.removeEventListener(event, handler, false);
 }
 
+function setAttribute(node, attribute, value) {
+	node.setAttribute(attribute, value);
+}
+
 function blankObject() {
 	return Object.create(null);
 }
@@ -206,7 +210,7 @@ function create_main_fragment(component, state) {
 
 		h: function hydrate() {
 			addListener(input, "change", input_change_handler);
-			input.type = "checkbox";
+			setAttribute(input, "type", "checkbox");
 		},
 
 		m: function mount(target, anchor) {

diff --git a/test/js/samples/input-without-blowback-guard/expected.js b/test/js/samples/input-without-blowback-guard/expected.js
@@ -1,5 +1,5 @@
 /* generated by Svelte vX.Y.Z */
-import { addListener, assign, createElement, detachNode, init, insertNode, proto, removeListener } from "svelte/shared.js";
+import { addListener, assign, createElement, detachNode, init, insertNode, proto, removeListener, setAttribute } from "svelte/shared.js";
 
 function create_main_fragment(component, state) {
 	var input;
@@ -16,7 +16,7 @@ function create_main_fragment(component, state) {
 
 		h: function hydrate() {
 			addListener(input, "change", input_change_handler);
-			input.type = "checkbox";
+			setAttribute(input, "type", "checkbox");
 		},
 
 		m: function mount(target, anchor) {