Merge pull request #3817 from sveltejs/revert-3812-tanhauhau/remove-e…

…mpty-value-declaration Revert "remove empty value declaration from style tree"
sveltejs · Oct 28, 2019 · f849408 · f849408
2 parents b6f4c23 + b59c942
commit f849408
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 21 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -69,7 +69,7 @@
     "eslint": "^6.3.0",
     "eslint-plugin-import": "^2.18.2",
     "eslint-plugin-svelte3": "^2.7.3",
-    "estree-walker": "^0.9.0",
+    "estree-walker": "^0.8.1",
     "is-reference": "^1.1.4",
     "jsdom": "^15.1.1",
     "kleur": "^3.0.3",

diff --git a/src/compiler/parse/read/style.ts b/src/compiler/parse/read/style.ts
@@ -31,7 +31,7 @@ export default function read_style(parser: Parser, start: number, attributes: No
 
 	// tidy up AST
 	walk(ast, {
-		enter(node: any) { // `any` because this isn't an ESTree node
+		enter: (node: any) => { // `any` because this isn't an ESTree node
 			// replace `ref:a` nodes
 			if (node.type === 'Selector') {
 				for (let i = 0; i < node.children.length; i += 1) {
@@ -47,10 +47,6 @@ export default function read_style(parser: Parser, start: number, attributes: No
 				}
 			}
 
-			if (node.type === 'Declaration' && node.value.type === 'Value' && node.value.children.length === 0) {
-				this.remove();
-			}
-
 			if (node.loc) {
 				node.start = node.loc.start.offset;
 				node.end = node.loc.end.offset;

diff --git a/test/css/samples/empty-value/expected.css b/test/css/samples/empty-value/expected.css
diff --git a/test/css/samples/empty-value/input.svelte b/test/css/samples/empty-value/input.svelte