Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outroing is not defined with nestedTransitions: true #1492

Closed
Rich-Harris opened this issue May 25, 2018 · 0 comments · Fixed by #1493
Closed

outroing is not defined with nestedTransitions: true #1492

Rich-Harris opened this issue May 25, 2018 · 0 comments · Fixed by #1493
Labels

Comments

@Rich-Harris
Copy link
Member

With the nestedTransitions: true option, it's possible to end up in a situation where one branch of an if block potentially has outros, but another doesn't, and Svelte checks for a non-existent outroing variable in the block that doesn't upon update.

{#if y}
	<Foo/>
{:else}
	<span>{x}</span>
{/if}

Noticed a couple of other things:

  • we don't really need to update the if block at all; perhaps that should be short-circuited anyway
  • transitionManager gets added even though there's no transitions, because it's trying to group the outros (in case <Foo> has some). I wonder if we can separate groupOutros from transitionManager so that it doesn't get pulled in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant