Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested transitions prevent items from being removed #1617

Closed
Rich-Harris opened this issue Jul 26, 2018 · 1 comment · Fixed by #1693
Closed

Nested transitions prevent items from being removed #1617

Rich-Harris opened this issue Jul 26, 2018 · 1 comment · Fixed by #1693
Labels
bug

Comments

@Rich-Harris
Copy link
Member

Looks like there is some stale state somewhere, and Svelte thinks items are in the process of being removed (or something) https://svelte.technology/repl?version=2.9.7&gist=1b5b2cc92dfb9af877487c464739df0f
@jacwright
Copy link
Contributor

Looks like the each_blocks array size isn't being adjusted. Will work on it.

screen shot 2018-08-25 at 12 52 07 pm

jacwright added a commit that referenced this issue Aug 25, 2018
@jacwright
Fix for each-blocks preventing outros from completing
4c2b960 
Unkeyed each blocks end up with trailing `null` values that prevent the whole from being outroed. This fixes it so the null values are removed before outroing the remaining blocks.

Fixes #1617
@jacwright jacwright mentioned this issue Aug 25, 2018
Merged
kaisermann pushed a commit to kaisermann/svelte that referenced this issue Sep 19, 2018
@Rich-Harris
Merge pull request sveltejs#1693 from sveltejs/sveltejsgh-1617
b4a3a60 
Fix for each-blocks preventing outros from completing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for each-blocks preventing outros from completing sveltejs/svelte
2 participants
@jacwright @Rich-Harris