Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions should be able to accept template strings as arguments. #1676

Closed
AGoblinKing opened this issue Aug 22, 2018 · 1 comment
Closed

Actions should be able to accept template strings as arguments. #1676

AGoblinKing opened this issue Aug 22, 2018 · 1 comment

Comments

@AGoblinKing
Copy link

https://svelte.technology/repl?version=2.9.5&gist=ad939c33265c86335cdb70f84c5eee41

Currently you cannot pass template strings to actions. This makes some use cases rather annoying to implement. ie: iterating over a list and passing data as a string.

Thanks!
jacwright added a commit that referenced this issue Aug 23, 2018
@jacwright
Allows actions to use any expression type
ba5ede5 
Allow any expression to pass data to an action. Added a test for a ternary statement and a string template.
Fixes #1676
@jacwright jacwright mentioned this issue Aug 23, 2018
Merged
@Rich-Harris
Copy link
Member

Fixed in 2.12.1 thanks to @jacwright 🎉

kaisermann pushed a commit to kaisermann/svelte that referenced this issue Sep 19, 2018
@Rich-Harris
Merge pull request sveltejs#1679 from sveltejs/sveltejsgh-1676
e450c30 
Allows actions to use any expression type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AGoblinKing @Rich-Harris