Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle continue $ #3469

Closed
Rich-Harris opened this issue Aug 28, 2019 · 2 comments
Closed

Handle continue $ #3469

Rich-Harris opened this issue Aug 28, 2019 · 2 comments
Labels
feature request

Comments

@Rich-Harris
Copy link
Member

Describe the bug

continue $ doesn't work inside a reactive loop

To Reproduce

https://twitter.com/donavon/status/1166770135329382400

Expected behavior

It compiles

Severity

Low. Total edge case

Additional context

https://twitter.com/Rich_Harris/status/1166775703213416448
@Conduitry
Copy link
Member

Conduitry commented Aug 28, 2019 •
edited
Loading

This seems adjacent to #2828. What eventually emerged in that issue was allowing break $. One way to handle all of this would be to just always leave in the $: when compiling. I would think minifiers would strip it out if it weren't used.

@Conduitry
Copy link
Member

(Unless it's changed again!) this will be resolved by #3539.

@Conduitry Conduitry mentioned this issue Oct 17, 2019
Merged
Conduitry added a commit that referenced this issue Oct 17, 2019
@Conduitry
preserve $: label in reactive blocks in SSR mode (#2828) (#3469)
dda9a53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rich-Harris @Conduitry