Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store value not set via $-prefix if not used in template #3537

Closed
PaulMaly opened this issue Sep 8, 2019 · 2 comments · Fixed by #3538
Closed

Store value not set via $-prefix if not used in template #3537

PaulMaly opened this issue Sep 8, 2019 · 2 comments · Fixed by #3538
Labels
bug

Comments

@PaulMaly
Copy link
Contributor

PaulMaly commented Sep 8, 2019

Code for updating store value doesn't generated if store value actually not used in the component even if it used in other components.

REPL: https://svelte.dev/repl/ebcbacf20ea3402c990c92c7caf81ac6?version=3.10.1

If uncomment store usage in template example start to works correctly.
@burningTyger
Copy link
Contributor

Should be mentioned that this worked in 3.10.0 as per repl url change

@Rich-Harris
Copy link
Member

thanks — looking into it

@Rich-Harris Rich-Harris added the bug label Sep 8, 2019
Rich-Harris added a commit that referenced this issue Sep 8, 2019
@Rich-Harris
invalidate store values in <script> block - fixes #3537
c12e7d6
@Rich-Harris Rich-Harris mentioned this issue Sep 8, 2019
Merged
Rich-Harris added a commit that referenced this issue Sep 8, 2019
@Rich-Harris
Merge pull request #3538 from sveltejs/gh-3537
50ae572 
invalidate store values in <script> block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

invalidate store values in <script> block sveltejs/svelte
3 participants
@burningTyger @Rich-Harris @PaulMaly