Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development mode warnings use array.prototype.includes which breaks bundle on IE 11 #3914

Closed
AndrewHoldaway opened this issue Nov 13, 2019 · 3 comments · Fixed by #3915
Closed
Labels

Comments

@AndrewHoldaway
Copy link

Describe the bug
When bundling in development mode the check for unknown props utilizes the Array.prototype.includes method which isn't supported on ie 11. This causes a break on ie11

Logs
image
image

Expected behavior
Conduitry suggested in the discord that this should be replaced with indexOf to avoid having to use a polyfill

Information about your Svelte project:

  • Your browser and the version: (IE 11)

  • Your operating system: (Windows 7)

  • Svelte version (3.12..1)

  • Whether your project uses Webpack or Rollup

Severity
Renders usage in IE 11 while developing useless so decently annoying. Requires excess polyfills simply to develop although it is not a blocking issue as adding a polyfill should fix the issue.

@Conduitry Conduitry added the bug label Nov 13, 2019
@Conduitry
Copy link
Member

caniuse says that IE doesn't support startsWith either, so we should replace that with something else as well.

@AndrewHoldaway
Copy link
Author

AndrewHoldaway commented Nov 13, 2019

This still seems to be used when dev is set to false with rollup plugin svelte

I was mistaken. Aggressive caching from the browser.

@Conduitry
Copy link
Member

In 3.14.1, we're now using indexOf instead of includes and slice instead of startsWith. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants