Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially remove "install size" npm badge from README. #4333

Closed
antony opened this issue Jan 28, 2020 · 1 comment · Fixed by #4334
Closed

Potentially remove "install size" npm badge from README. #4333

antony opened this issue Jan 28, 2020 · 1 comment · Fixed by #4334
Assignees

Comments

@antony
Copy link
Member

antony commented Jan 28, 2020

I'm wondering if it's prudent to remove the npm install size badge (2.93mb) from the ReadMe. Because Svelte is a compiler, the installed npm module size doesn't have any bearing on the product, and is likely to be interpreted as something which would increase the end bundle size, which isn't accurate at all. It's misleading and confusing.

I'm not exactly sure why it is there in the first place - the info is available should anybody really want to know (such as embedding the Svelte compiler into another project). It's certainly not "top of readme" level information.

How important is this feature to you?
I'd prefer it.

@antony antony self-assigned this Jan 28, 2020
antony added a commit that referenced this issue Jan 28, 2020
@Conduitry
Copy link
Member

Yeah, this was added in #2702, but I don't really have any idea why it was added. Removing it sounds good to me.

Conduitry pushed a commit that referenced this issue Jan 28, 2020
jesseskinner pushed a commit to jesseskinner/svelte that referenced this issue Feb 27, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this issue Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants