Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested component with if weirdness #592

Closed
Conduitry opened this issue May 21, 2017 · 2 comments
Closed

Nested component with if weirdness #592

Conduitry opened this issue May 21, 2017 · 2 comments
Labels
bug

Comments

@Conduitry
Copy link
Member

Apologies for the vague title, but I don't know how to distill the problem I ran across any further. The REPL seems to be acting wonky with multiple components currently, so I've created a failing unit test instead. Branch incoming.
Conduitry added a commit that referenced this issue May 21, 2017
@Conduitry
add failing unit test for #592
5c0d402
@Conduitry
Copy link
Member Author

As the bug is identified better, perhaps the unit test can be refined as well. Right now it doesn't have any asserts, as simply doing the two .sets in it throws an exception.

Rich-Harris added a commit that referenced this issue May 27, 2017
@Rich-Harris
Merge branch 'master' into gh-592
77fb38a
@Rich-Harris Rich-Harris mentioned this issue May 28, 2017
Merged
Rich-Harris added a commit that referenced this issue May 28, 2017
@Rich-Harris
Merge branch 'master' into gh-592
f511962
@Rich-Harris Rich-Harris mentioned this issue May 28, 2017
Closed
Rich-Harris added a commit that referenced this issue Jun 1, 2017
@Rich-Harris
merge master -> gh-592
3b70920
Rich-Harris added a commit that referenced this issue Jun 1, 2017
@Rich-Harris
Merge pull request #603 from sveltejs/gh-592
c3fb711 
[WIP] Separate unmount from destroy
@Rich-Harris
Copy link
Member

Fixed in 1.22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rich-Harris @Conduitry