Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Each block inside slotted content does not get updated #927

Closed
cristinecula opened this issue Nov 14, 2017 · 1 comment · Fixed by #932
Closed

Each block inside slotted content does not get updated #927

cristinecula opened this issue Nov 14, 2017 · 1 comment · Fixed by #932
Labels
bug

Comments

@cristinecula
Copy link
Contributor

I ran across a slight issue with each blocks and slotted content: if the each block outputs directly to a slot, the state updates are not rendered. If the each block is wrapped with an element, it works:

https://svelte.technology/repl?version=1.41.3&gist=64a25260abf9c36de5bb0b4d244499e7
Rich-Harris added a commit that referenced this issue Nov 18, 2017
@Rich-Harris
failing test for #927
0ee59a0
Rich-Harris added a commit that referenced this issue Nov 23, 2017
@Rich-Harris
Merge branch 'master' into gh-927
5f84375
Rich-Harris added a commit that referenced this issue Nov 23, 2017
@Rich-Harris
append to the dom, not a document fragment, when updating each block …
2f86266 
…in slot - fixes #927
@Rich-Harris Rich-Harris mentioned this issue Nov 23, 2017
Merged
Rich-Harris added a commit that referenced this issue Nov 23, 2017
@Rich-Harris
append to the dom, not a document fragment, when updating each block …
d32328c 
…in slot - fixes #927
@Rich-Harris
Copy link
Member

Thanks! Fixed in 1.42.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

append to the dom, not a document fragment, when updating each block in slot sveltejs/svelte
2 participants
@cristinecula @Rich-Harris