Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions broken in version 1.43.0 #962

Closed
ekhaled opened this issue Nov 27, 2017 · 4 comments
Closed

Transitions broken in version 1.43.0 #962

ekhaled opened this issue Nov 27, 2017 · 4 comments

Comments

@ekhaled
Copy link
Contributor

ekhaled commented Nov 27, 2017

Maybe it's related to the work on #956

None of the transitions work anymore, and we get an error from rollup Cannot read property 'snippet' of undefined

This is a link directly from the user guide examples for transitions

You will see the error as soon as you open the example in the REPL.

@ekhaled
Copy link
Contributor Author

ekhaled commented Nov 27, 2017

Addendum:
Works perfectly in 1.42.0
but does not work in 1.42.1

Rich-Harris added a commit that referenced this issue Nov 27, 2017
allow parameterised transitions
@ekhaled
Copy link
Contributor Author

ekhaled commented Nov 27, 2017

@Rich-Harris I think this is not completely solved yet.

Compare this (shows an error message) with this (works perfectly)

To clarify, when transition parameters are sent from data it barfs in 1.43.1. Whereas, it used to work perfectly fine in 1.42.0

@ekhaled
Copy link
Contributor Author

ekhaled commented Nov 30, 2017

This REPL works.

@Rich-Harris can this issue be reopened please?

It seems that it can evaluate scope variables inside each blocks, but cannot evaluate items from inside data itself.

@Rich-Harris Rich-Harris reopened this Dec 3, 2017
Rich-Harris added a commit that referenced this issue Dec 3, 2017
don't transform bidi transitions twice
@Rich-Harris
Copy link
Member

Thanks @ekhaled — this is fixed in 1.44.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants