Rework handling of non-root <script> and <style> #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1163 +/- ##
==========================================
+ Coverage 91.51% 91.71% +0.19%
==========================================
Files 126 126
Lines 4526 4536 +10
Branches 1462 1465 +3
==========================================
+ Hits 4142 4160 +18
+ Misses 163 158 -5
+ Partials 221 218 -3
Continue to review full report at Codecov.
|
|
awesome 👍 |
|
Heh I pushed one more fix to this branch riiiiight after you merged it, so I just went ahead and committed it right to master. |
|
Cool — looks like I'd already pulled it before I cut the new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In practical terms, this fixes hydration of non-root <script> and <style>, and also fixes tag interpolation in non-root <style> (#1147). This supersedes other previous PRs I'd opened.
This switches non-root <script> and <style> back to being parsed as regular elements containing one child Text node (in the case of <script>) and one or more Text or Tag nodes (in the case of <style>). There are also some other changes to make sure we don't escape HTML special characters in DOM or SSR mode for the Text nodes inside non-root <script> and <style> elements.