fix capitalize warning #1179
Merged
fix capitalize warning #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1179 +/- ##
=======================================
Coverage 91.75% 91.75%
=======================================
Files 127 127
Lines 4572 4572
Branches 1495 1495
=======================================
Hits 4195 4195
Misses 159 159
Partials 218 218
Continue to review full report at Codecov.
|
|
Should throw a test in there ;) |
Conduitry
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current 'is the component name capitalized?' check disregards the possibility of the first character being
_or$. The upcoming version of Sapper has components with names like_4xxand_5xx, so this PR checks that the first character isn'ta-zrather than checking that it isA-Z. I think that's a sensible fix