Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't treat :foo as a directive #1245

Merged
merged 3 commits into from
Mar 15, 2018
Merged

don't treat :foo as a directive #1245

merged 3 commits into from
Mar 15, 2018

Conversation

Rich-Harris
Copy link
Member

small tweak to #1242 — also fixes the over-specific regex.

Also disallows ref:foo='bar' etc — unlike other directives, refs don't have a value

@codecov-io
Copy link

codecov-io commented Mar 15, 2018

Codecov Report

Merging #1245 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1245      +/-   ##
==========================================
- Coverage    91.9%   91.89%   -0.01%     
==========================================
  Files         126      126              
  Lines        4557     4554       -3     
  Branches     1486     1485       -1     
==========================================
- Hits         4188     4185       -3     
  Misses        153      153              
  Partials      216      216
Impacted Files Coverage Δ
src/parse/read/directives.ts 86.44% <100%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f866bb...39694c3. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 270e1d1 into master Mar 15, 2018
@Rich-Harris Rich-Harris deleted the gh-1242-followup branch March 15, 2018 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants