-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix backtick string literals not being recognized in the svg/tag/props properties #1285
Fix backtick string literals not being recognized in the svg/tag/props properties #1285
Conversation
Failing test for sveltejs#1284 Fixes sveltejs#1284
Codecov Report
@@ Coverage Diff @@
## master #1285 +/- ##
==========================================
+ Coverage 91.55% 91.62% +0.06%
==========================================
Files 121 122 +1
Lines 4324 4333 +9
Branches 1362 1368 +6
==========================================
+ Hits 3959 3970 +11
+ Misses 153 150 -3
- Partials 212 213 +1
Continue to review full report at Codecov.
|
I think we'd want to make sure that this is a template string with no actual |
Aye, that's what the |
Want that done in this PR? |
Yes please I think that'd be good |
Failing test for #1284
Fixes #1284