Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom events on <:Window> #1315

Merged
merged 1 commit into from
Apr 4, 2018
Merged

support custom events on <:Window> #1315

merged 1 commit into from
Apr 4, 2018

Conversation

Rich-Harris
Copy link
Member

fixes #1268.

Again, I'm being slightly lazy about DRY because I feel a big refactoring coming on. Will throw up a new issue describing what I mean

@codecov-io
Copy link

codecov-io commented Apr 4, 2018

Codecov Report

Merging #1315 into master will decrease coverage by 0.02%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1315      +/-   ##
=========================================
- Coverage   91.53%   91.5%   -0.03%     
=========================================
  Files         124     124              
  Lines        4419    4427       +8     
  Branches     1391    1393       +2     
=========================================
+ Hits         4045    4051       +6     
- Misses        154     155       +1     
- Partials      220     221       +1
Impacted Files Coverage Δ
src/validate/html/validateWindow.ts 88.23% <100%> (+0.73%) ⬆️
src/generators/nodes/Window.ts 80% <77.77%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8717ff8...6ef808c. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 84019b5 into master Apr 4, 2018
@Rich-Harris Rich-Harris deleted the gh-1268 branch April 4, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom events not working on <:Window>
2 participants