-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: take snippets into account when scoping CSS #13589
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'svelte': patch | ||
--- | ||
|
||
fix: take snippets into account when scoping CSS |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import { test } from '../../test'; | ||
|
||
export default test({ | ||
warnings: [ | ||
{ | ||
code: 'css_unused_selector', | ||
message: 'Unused CSS selector "span div"', | ||
start: { | ||
line: 31, | ||
column: 1, | ||
character: 461 | ||
}, | ||
end: { | ||
line: 31, | ||
column: 9, | ||
character: 469 | ||
} | ||
} | ||
] | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
|
||
div.svelte-xyz > span:where(.svelte-xyz) { | ||
color: green; | ||
} | ||
div.svelte-xyz span:where(.svelte-xyz) { | ||
color: green; | ||
} | ||
div.svelte-xyz span { | ||
color: green; | ||
} | ||
p.svelte-xyz span:where(.svelte-xyz) { | ||
color: green; | ||
} | ||
p.svelte-xyz .foo:where(.svelte-xyz) { | ||
color: purple; /* doesn't match, but our static analysis doesn't handle this currently */ | ||
} | ||
/* (unused) span div { | ||
color: red; | ||
}*/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
<div class="svelte-xyz"><span class="svelte-xyz">Hello world</span></div> | ||
<p class="svelte-xyz"><strong><span class="svelte-xyz">Hello world</span></strong></p> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
{#snippet my_snippet()} | ||
<span>Hello world</span> | ||
{/snippet} | ||
|
||
<div>{@render my_snippet()}</div> | ||
|
||
<p> | ||
{#snippet my_snippet()} | ||
<span>Hello world</span> | ||
{/snippet} | ||
|
||
<strong>{@render my_snippet()}</strong> | ||
</p> | ||
|
||
<style> | ||
div > span { | ||
color: green; | ||
} | ||
div span { | ||
color: green; | ||
} | ||
div :global(span) { | ||
color: green; | ||
} | ||
p span { | ||
color: green; | ||
} | ||
p .foo { | ||
color: purple; /* doesn't match, but our static analysis doesn't handle this currently */ | ||
} | ||
span div { | ||
color: red; | ||
} | ||
</style> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we traverse backwards through the selectors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wdym? We're traversing them back to front. That's what the rest of the pruning algorithm does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean a for loop with negative index rather copying the array and popping each item
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The result of pop isn't passed to anything, the resulting array that is one item less afterwards is. Looping with negative index wouldn't change the fact that we have to create a new array, if that's what you're concerned about (in fact we would have to create more since we'd have to do it for each iteration of the inner loop, rather of only each iteration of the outer loop)