Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

width and height bindings #1386

Merged
merged 8 commits into from
Apr 30, 2018
Merged

width and height bindings #1386

merged 8 commits into from
Apr 30, 2018

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Apr 29, 2018

See #984. Progress is blocked by #1385 so I'll merge that

This turned out well. One wrinkle: it doesn't work with SVG elements (other than <svg> itself) — not sure if there's a clever alternative.

@Rich-Harris Rich-Harris changed the title [WIP] width and height bindings width and height bindings Apr 29, 2018
@codecov-io
Copy link

codecov-io commented Apr 29, 2018

Codecov Report

Merging #1386 into master will increase coverage by 0.01%.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1386      +/-   ##
==========================================
+ Coverage   91.19%   91.21%   +0.01%     
==========================================
  Files         122      122              
  Lines        4465     4484      +19     
  Branches     1377     1384       +7     
==========================================
+ Hits         4072     4090      +18     
  Misses        156      156              
- Partials      237      238       +1
Impacted Files Coverage Δ
src/utils/patterns.ts 100% <100%> (ø) ⬆️
src/compile/nodes/Element.ts 93.03% <100%> (+0.15%) ⬆️
src/compile/nodes/Binding.ts 96.07% <100%> (+0.07%) ⬆️
src/validate/html/validateElement.ts 85.58% <85.71%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d010aff...8f8b130. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 14f84a3 into master Apr 30, 2018
@Rich-Harris Rich-Harris deleted the gh-984 branch April 30, 2018 23:50
@ekhaled
Copy link
Contributor

ekhaled commented May 1, 2018

Do we get an on:resize event for free because of this?

@Rich-Harris
Copy link
Member Author

afraid not! just the bindings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants