Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows fragment updates to happen after state updates #1654

Closed
wants to merge 1 commit into from
Closed

Allows fragment updates to happen after state updates #1654

wants to merge 1 commit into from

Conversation

jacwright
Copy link
Contributor

Proposed fix for #1520 where a component can have stale data if some of its data comes from the store and some of its data comes from the parent which got it from the store.

This PR is a starting point for discussion.

@jacwright
Copy link
Contributor Author

I didn't like having to store changed/oldState on the component between a "set" and a "render" but felt it was necessary since when the render happens a _set can be called on a child with only the data from the parent component but the child must update with all the changes from store.set({ ... }) at once.

@jacwright
Allows fragment updates to happen after state updates
2c24c36 
Proposed fix for #1520. Provides a starting point for discussion.
@jacwright
Copy link
Contributor Author

Closing in favor of #1691.

@jacwright jacwright closed this Aug 25, 2018
@jacwright jacwright deleted the gh-1520 branch August 25, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Awaiting requested review from Rich-Harris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jacwright