Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make null the default anchor of insertBefore #2616

Merged
merged 1 commit into from
May 4, 2019
Merged

Make null the default anchor of insertBefore #2616

merged 1 commit into from
May 4, 2019

Conversation

EmilTholin
Copy link
Member

This PR defaults the second argument of insertBefore to null, so that environments that require that the anchor is either a node or null won't throw an error when the anchor is undefined.

Fixes #2573

@Rich-Harris Rich-Harris merged commit ab711ac into sveltejs:master May 4, 2019
@Rich-Harris
Copy link
Member

wow! that's a new one on me. good catch

@EmilTholin EmilTholin deleted the insertBefore_null_default_anchor branch May 4, 2019 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give insertBefore a Node or null as anchor
2 participants
@EmilTholin @Rich-Harris