Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix each blocks not unmounting components correctly #3056

Merged
merged 3 commits into from
Jun 19, 2019
Merged

Fix each blocks not unmounting components correctly #3056

merged 3 commits into from
Jun 19, 2019

Conversation

btk5h
Copy link
Contributor

@btk5h btk5h commented Jun 19, 2019

This should fix #3055. This PR prevents outro_and_destroy_block from calling block.d() in the transition_out callback, since transition_out already calls block.d().

@Conduitry
Copy link
Member

Conduitry commented Jun 19, 2019 •
edited
Loading

This looks to also help #3051. If I really go crazy on the todo list, I can get some weird behavior, but that's happening in 3.5.1 as well. This change makes it much more stable than it is in 3.5.2.

@Conduitry
Copy link
Member

This also looks like it takes care of the additional error mentioned here

@Rich-Harris Rich-Harris merged commit 7b5f176 into sveltejs:master Jun 19, 2019
@Rich-Harris
Copy link
Member

legend, thank you!

@btk5h btk5h deleted the gh-3055 branch June 19, 2019 23:43
This was referenced Sep 17, 2021
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conduitry Conduitry Conduitry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3.5.2 breaks unmounting components in keyed each blocks
3 participants
@btk5h @Conduitry @Rich-Harris