Fixed bug with slot props variables #3122
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2586
Fixes issue when declaring and initializing a variable used in a slot.
The variable is hoisted and subsequently not added to filtered_declarations. The return statement for the component instance would be
return { $$slots, $$scope };
when it should be
return { worldText, $$slots, $$scope };
Test component-slot-let-e will fail when worldText is not part of the return object.
Other slot tests did not fail because the on:click handler caused the variable to be not be hoisted.