Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should throw error if createEventDispatch is used after instantiation #3667

Conversation

tanhauhau
Copy link
Member

I read the tutorial and it says

createEventDispatcher must be called when the component is first instantiated, — you can't do it later inside e.g. a setTimeout callback.

however it does not show error if i use it in a setTimeout callback.

I only see an obscure error Uncaught TypeError: Cannot read property '$$' of undefined later on when I tried to dispatch an event.

Should I make this a compile time warning? or a runtime error?

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@Conduitry Conduitry merged commit d54ef0c into sveltejs:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants