Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove empty value declaration from style tree #3812

Merged

Conversation

tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented Oct 28, 2019

Fix #3801
If the value is empty, will cause compile error down the road.
Remove it upfront, will be able to treat it as empty rule, if there's no other declaration for the rule.

@Rich-Harris
Copy link
Member

I merged this but then reverted it — I think we should probably be throwing a deliberate error here

@tanhauhau
Copy link
Member Author

But it's a valid syntax to the css-tree/parser?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing error message "TypeError: Cannot read property 'start' of undefined" with invalid css
2 participants