fix: bitmask overflow better handle global #4063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanhauhau
force-pushed
the
tanhauhau/bitmask-overflow-with-global-variable
branch
3 times, most recently
from
6188acf
to
6945862
Compare
Conduitry
reviewed
Dec 9, 2019
| if (member.index.value === -1) { | ||
| throw new Error(`unset index`); | ||
| } | ||
| if (!member) return bitmask; |
There was a problem hiding this comment.
Returning bitmask doesn't actually do anything anymore, right? We should just be returning here, because this is a forEach now (and the return bitmask; at the end should be completely removed I think).
|
Haha oops thanks. I was just about to push that. I misread which parts were inside the forEach. |
|
no worries. 😏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4037
namesare not in context.dirty & 0to match the current output.bitmaskarray, the dirtyExpression#typecould have been accessed multiple times, causing the bitmask to be re-calculated more than once.getterindirection