Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4061 #4091

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Fixes #4061 #4091

merged 2 commits into from
Dec 11, 2019

Conversation

RedHatter
Copy link
Contributor

Fixes #4061 where changes to let directives where not being passed to nested slots. I feel like I'm missing something though. Why was filtering let dependencies (non_let_dependencies) thought to be necessary in the first place?

In light of this fix I'm also suspicious of lines 94-103

const dependencies: Set<string> = new Set();

// TODO is this filtering necessary? (I *think* so)
default_slot.dependencies.forEach(name => {
	if (!this.node.scope.is_let(name)) {
		dependencies.add(name);
	}
});

block.add_dependencies(dependencies);

It looks to be doing something similar but I'm not sure what its exact effect is. The issue is solved without removing line 98 but I wonder if it's causing some other subtle bug.

@Conduitry Conduitry merged commit 2cd5c29 into sveltejs:master Dec 11, 2019
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slot with props doesn't propergate changes
2 participants