Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chore): configure pre-commit hook #4123

Closed

Conversation

jamesgeorge007
Copy link
Contributor

pre-commit hooks come in handy in the entire Dev workflow. Now the lint script is automatically executed before making a commit on staged files.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be fine on your own fork, but I'm not sure this is appropriate for the project as a whole.

I, for one, create many commits and tend to rebase/re-arrange/etc and these pre-commit hooks will add an unbearable amount of overhead to that workflow.

@Conduitry
Copy link
Member

Thanks, but yeah, this is something that we don't want to force on everyone. I'm not thrilled about introducing all of these extra dependencies, or about introducing more stuff that gets run on postinstall, or about automatically adding git hooks for people that they don't necessarily want.

We already have CI to catch this stuff once a PR is opened. And I often commit partially complete code while working on something, and I don't want to have to wait for linting on every commit or have the commit fail because I haven't tidied up all of the linting errors in my intermediate code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants