Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat better error message for else, elseif, then, catch with unclosed tag #4136

Merged
merged 8 commits into from
Feb 9, 2020
Merged

feat better error message for else, elseif, then, catch with unclosed tag #4136

merged 8 commits into from
Feb 9, 2020

Conversation

tanhauhau
Copy link
Member

Fixes #4131

ghost
ghost suggested changes Dec 23, 2019
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest also testing empty/void tags such as <input> an <br> to make sure they don't cause a false positive.

@tanhauhau tanhauhau force-pushed the tanhauhau/parser-error-for-unclosed-tag branch from 03e9ad4 to 4e3f840 Compare December 24, 2019 16:24
@Conduitry Conduitry merged commit 2195832 into sveltejs:master Feb 9, 2020
@tanhauhau tanhauhau deleted the tanhauhau/parser-error-for-unclosed-tag branch February 9, 2020 14:20
jesseskinner pushed a commit to jesseskinner/svelte that referenced this pull request Feb 27, 2020
@tanhauhau @jesseskinner
better error messages for else, elseif, then, catch with unclosed tag (…
526f350 
…sveltejs#4136)
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
@tanhauhau @taylorzane
better error messages for else, elseif, then, catch with unclosed tag (…
5a8e76a 
…sveltejs#4136)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misleading error message, when only open tag is in if else block
2 participants
@tanhauhau @Conduitry