Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: clarify preserveWhitespace #4341

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Conversation

Conduitry
Copy link
Member

Hopefully this is clear enough to resolve #4337.

Copy link
Member

@tanhauhau tanhauhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably providing a case that shows the difference between preserveWhitespace=false and preserveWhitespace=true, will make it clearer?

@Rich-Harris
Copy link
Member

There are some cases where whitespace is removed altogether — I'll amend the text to reflect that. I'm not sure we have room to add examples of the two alternatives here

@Rich-Harris Rich-Harris merged commit 83d461f into sveltejs:master Jan 31, 2020
@Conduitry Conduitry deleted the gh-4337 branch January 31, 2020 19:59
@Prinzhorn
Copy link
Contributor

Thanks, it does make it more clear.

sthagen added a commit to sthagen/sveltejs-svelte that referenced this pull request Feb 2, 2020
site: clarify preserveWhitespace (sveltejs#4341)
jesseskinner pushed a commit to jesseskinner/svelte that referenced this pull request Feb 27, 2020
* site: clarify preserveWhitespace

* Update 04-compile-time.md

Co-authored-by: Rich Harris <[email protected]>
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
* site: clarify preserveWhitespace

* Update 04-compile-time.md

Co-authored-by: Rich Harris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preserveWhitespace does not behave according to the docs or the docs are vague rather
4 participants