Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using shift in flush #4356

Merged
merged 2 commits into from
Feb 8, 2020
Merged

Avoid using shift in flush #4356

merged 2 commits into from
Feb 8, 2020

Commits on Feb 3, 2020

  1. Avoid using shift in flush 

    We noticed that there was a large amount of memory being created as part of the flush method, which seems to be due to some array optimizations in old JS engines. This seems to be easily fixed by changing to a simple for loop instead of a while loop that modifies the array during iteration. This is the same pattern that is used for the `render_callbacks`.
    @kesne
    kesne authored Feb 3, 2020
    Configuration menu
    Copy the full SHA
    45053c2 View commit details
    Browse the repository at this point in the history

  2. Keep track of flushing state

    Jordan Gensler committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    508d523 View commit details
    Browse the repository at this point in the history