Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn if passing slot not defined into Component #4501

Merged
merged 7 commits into from
Mar 5, 2020
Merged

warn if passing slot not defined into Component #4501

merged 7 commits into from
Mar 5, 2020

Conversation

tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented Mar 3, 2020 •
edited
Loading

Fixes #1020, Fixes #1447

Failed test case will be fixed by #4500

Not sure the warning message is clear enough.

@tanhauhau tanhauhau added the slot label Mar 3, 2020
@Conduitry
Copy link
Member

After #4500 was merged, I locally merged master back into this branch, but I'm still seeing a test failure for sigil-component-prop. The failure (due to an unexpected warning) goes away if I remove the newline inside the <Widget> component contents in that test. I'm not sure how this is interacting with #4500, but I'd probably expect that whitespace-only default slots not count as a slot getting passed into the component.

@tanhauhau tanhauhau force-pushed the tanhauhau/warn-if-passing-slot-not-defined branch from a89c3b0 to d9388ca Compare March 4, 2020 14:42
@tanhauhau
Copy link
Member Author

tanhauhau commented Mar 4, 2020 •
edited
Loading

I found out why it failed, because in dev mode, we added dispatch_dev$("SvelteRegisterBlock", {}) into the block, that's why the slot block wasn't considered "empty".

@Conduitry Conduitry merged commit f2ee7ef into sveltejs:master Mar 5, 2020
@tanhauhau tanhauhau deleted the tanhauhau/warn-if-passing-slot-not-defined branch March 5, 2020 00:57
@Conduitry
Copy link
Member

Conduitry commented Mar 5, 2020 •
edited
Loading

I don't know why GitHub attributed the squashed commit to me and not to you 😬 I don't think I did anything different than usual...

Edit: Maybe because three commits were yours and four were mine? I don't really have any idea.

hontas added a commit to hontas/svelte that referenced this pull request Mar 6, 2020
@hontas
Merge branch 'master' of https://github.com/sveltejs/svelte
7d9ff14 
* 'master' of https://github.com/sveltejs/svelte: (137 commits)
  -> v3.19.2
  fix lazy code breaks in build
  fit bitmask overflow initial dirty value in 'if' blocks (sveltejs#4507)
  add dev runtime warning for unknown slot names (sveltejs#4501)
  fix render fallback slot content due to whitespace (sveltejs#4500)
  docs: describe falsy and nullish attribute behavior (sveltejs#4498)
  in spread, distinguish never-updating and always-updating props (sveltejs#4487)
  chore: more specific typings, and add README note about Yarn (sveltejs#4483)
  update changelog
  check for unknown props even if component doesn't have writable props (sveltejs#4454)
  Bump codecov from 3.5.0 to 3.6.5 (sveltejs#4433)
  fix bitmask overflow for slot (sveltejs#4485)
  mark module variables as mutated or reassigned (sveltejs#4469)
  docs: referenced_from_script var value (sveltejs#4486)
  docs: clarify default prop behaviour (sveltejs#4460)
  site: turn fancybutton into custombutton (sveltejs#4476)
  update changelog
  exclude global variables from $capture_state (sveltejs#4475)
  -> v3.19.1
  don't treat $$-names as stores during invalidation (sveltejs#4453)
  ...
@Conduitry Conduitry mentioned this pull request Mar 12, 2020
Closed
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
@Conduitry @taylorzane
add dev runtime warning for unknown slot names (sveltejs#4501)
1db1096
@baseballyama baseballyama mentioned this pull request May 5, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tanhauhau @Conduitry