complain if named slots other than direct descendant of component #4509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanhauhau
force-pushed
the
tanhauhau/feat-warn-named-slots-other-than-top-level
branch
from
d9ece3c
to
0e219ab
Compare
tanhauhau
force-pushed
the
tanhauhau/feat-warn-named-slots-other-than-top-level
branch
from
0e219ab
to
d185a20
Compare
Conduitry
reviewed
Mar 8, 2020
tanhauhau
commented
Mar 9, 2020
| @@ -395,7 +395,7 @@ export default class Element extends Node { | |||
| component.slot_outlets.add(name); | |||
| } | |||
|
|
|||
| if (!(parent.type === 'InlineComponent' || (parent.type === 'Element' && /-/.test(parent.name)))) { | |||
| if (!(parent.type === 'InlineComponent' || within_custom_element(parent))) { | |||
There was a problem hiding this comment.
we can actually allow it if it is within custom element, since we are going to create them just like a normal element, browser will figure out itself
There was a problem hiding this comment.
this relates to #1689 (comment)
There was a problem hiding this comment.
Should the error message be adjusted then? Something like 'must be a direct child of a component or a descendant of a custom element'?
There was a problem hiding this comment.
yup! updated the error message
2 tasks
taylorzane
pushed a commit
to taylorzane/svelte
that referenced
this pull request
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3385
allow nested named slots if it is within custom element