a11y: warn about href="javascript:void(0)" #4733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conduitry
reviewed
Apr 27, 2020
| @@ -428,7 +428,7 @@ export default class Element extends Node { | |||
| if (attribute) { | |||
| const value = attribute.get_static_value(); | |||
|
|
|||
| if (value === '' || value === '#') { | |||
| if (value === '' || value === '#' || /^\W*?javascript/.test(value)) { | |||
There was a problem hiding this comment.
The ? here after the * doesn't do anything - and we should be testing for javascript:, not just javascript. There's nothing wrong with linking to paths that happen to begin with javascript.
bwbroersma
reviewed
Apr 28, 2020
| @@ -428,7 +428,7 @@ export default class Element extends Node { | |||
| if (attribute) { | |||
| const value = attribute.get_static_value(); | |||
|
|
|||
| if (value === '' || value === '#' || /^\W*?javascript/.test(value)) { | |||
| if (value === '' || value === '#' || /^\W*javascript:/.test(value)) { | |||
There was a problem hiding this comment.
A case insensitive check should be done, since URI schemes are case insensitive RFC 2396:
/^\W*javascript:/i.test(value)There was a problem hiding this comment.
thanks for the information!
|
This has been released in 3.22.0 - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
href="javascript:void(0)"is not recommended for a11y and maybe it would be great if svelte can warn about it.Note
Besides, would it be great to warn about something like:
as well? If so I'm willing to help or have an issue about this.
Tests
npm testoryarn test)